Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution guide for WPF UI #13

Closed
BrianLima opened this issue Mar 27, 2017 · 4 comments
Closed

Contribution guide for WPF UI #13

BrianLima opened this issue Mar 27, 2017 · 4 comments

Comments

@BrianLima
Copy link

BrianLima commented Mar 27, 2017

Hi @fabsenet, i'm a developer looking for side projects, i'm currently working on my Arduino/LED application, i've built some WPF UI's in the past and i'm using your app on my TV setup, but i can help with a better UI for it, what do you need and aim for with your UI? What style do you like? Would you want a more basic WPF look or a more customized one (I personally love Material XAML)?

@fabsenet
Copy link
Owner

hi @BrianLima ,

sounds great, i was thinking to do this for quite some time myself as well. A nice material design would be great and if you are used to material xaml, then use it. the course of action could be:

  • splitting the data and "business" logic out of the windows form into a viewmodel
  • making a wpf window and using this new viewmodel

I was thinking of some more tabs inside the view to better split between different aspects of adrilight. For example:

  • LED setup
  • Color correction setup
  • source selection
    • dektop duplication input with preview ("what does adrilight actually see?")
    • alternate sources like solid color, color animations, sound input. but solid color at first to help new user in error resulution
  • ...

you can either start bei making the viewmodel or by making a business logic free material design gui and we do the viewmodel after that. I would suggest you fork adrilight, make yourself a new branch and open up a pull request, when you have at least a little start.

We should take a look early and often so we are both sure to aim for the same target.

@fabsenet
Copy link
Owner

fabsenet commented Mar 31, 2017

I cannot tell whether you are coding in the dark or got distracted with life and things?!

@BrianLima
Copy link
Author

Just a little bit busy, i'll start my branch soon.

@fabsenet
Copy link
Owner

In case you still wanting to contribute, please start an early pull request. closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants