[Bug]: Blank terminal window pops up on install

[Madis0]

Code of Conduct

• I agree to follow this project's Code of Conduct

What happened?

Upon clicking the install button, a blank terminal window pops open. That doesn't seem necessary, just launch whatever you need from Python's OS commands.

Version

Beta release

What platform are you using?

Windows

How did you download the software?

GitHub Releases

Relevant log output

No response

Additional data and screenshots

No response

[osfanbuff63]

this doesn't happen with me, don't know what's happening here

[Madis0]

[osfanbuff63]

Oh...maybe it's using java.exe instead of javaw.exe? It's supposed to use javaw on Windows, but the underlying mll function could be getting that path instead somehow?

[Madis0]

(hovering on that tab)

[osfanbuff63]

https://gitlab.com/JakobDev/minecraft-launcher-lib/-/blob/master/minecraft_launcher_lib/utils.py#L89

Yeah, this doesn't get the path to javaw.exe (instead java.exe), so I'm going to have to change that section to being done manually.

[osfanbuff63]

This should be fixed in the next build.

[osfanbuff63]

Correction: This is fixed now, with the update to minecraft_launcher_lib. (I think I bumped that?)