Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

[Feature Request]: Separate instance #61

Open
1 task done
Madis0 opened this issue Jan 3, 2023 · 6 comments · May be fixed by #117
Open
1 task done

[Feature Request]: Separate instance #61

Madis0 opened this issue Jan 3, 2023 · 6 comments · May be fixed by #117
Labels
enhancement New feature or request

Comments

@Madis0
Copy link
Member

Madis0 commented Jan 3, 2023

Code of Conduct

  • I agree to follow this project's Code of Conduct

Potential Enhancement

A checkbox that would install the modpack to a separate folder inside .minecraft

How it could be implemented

A checkbox in the GUI. Folder name could be Fabulously Optimized x.x.x for example, where x.x.x is the Minecraft version so it can be easily updated by subsequent installs.

Anything else?

No response

@Madis0 Madis0 added the enhancement New feature or request label Jan 3, 2023
@osfanbuff63
Copy link
Member

This is already supported by the file dialog to select a folder so you could select any folder anywhere - especially since from everything I've heard recently, you shouldn't nest instances inside .minecraft, you should use a different folder inside pretty much anywhere else.

We might still want to implement this, but not sure.

@Madis0
Copy link
Member Author

Madis0 commented Jan 3, 2023

Well, if I select a new folder outside .minecraft, e.g. .minecraft-2, it gets stuck on setting profiles.

@osfanbuff63
Copy link
Member

Well, if I select a new folder outside .minecraft, e.g. .minecraft-2, it gets stuck on setting profiles.

Well that's apparently a bug...you don't need to file a new ticket for it unless you want to, we have enough 😅. What's probably happening is that dir is being passed to the create profile function, which needs to be .minecraft since that's the only place that file exists.

@Madis0
Copy link
Member Author

Madis0 commented Jan 3, 2023

Indeed, the installer needs to know where .minecraft is, so I wouldn't exactly consider that a bug if I don't tell it where it is :D

So separate profiles should be either inside or next to .minecraft, IMO letting users define the specific path/folder name is not necessary.

@tuxinal
Copy link
Contributor

tuxinal commented Jan 15, 2023

What's probably happening is that dir is being passed to the create profile function, which needs to be .minecraft since that's the only place that file exists.

We could hardcode the .minceraft folder for the create profile function since the only way for it to need another value is to change the launcher's working directory which can only be changed through command line options. at which point we can assume the user knows enough to not be troubled by this.

@Madis0
Copy link
Member Author

Madis0 commented Jan 15, 2023

We could hardcode the .minceraft folder for the create profile function since the only way for it to need another value is to change the launcher's working directory which can only be changed through command line options. at which point we can assume the user knows enough to not be troubled by this.

I don't agree with that, Minecraft Launcher can also be used as portable, in a different hard drive or various methods in Linux.

@osfanbuff63 osfanbuff63 linked a pull request Apr 7, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants