Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

[Feature Request]: Warn on downgrades #80

Open
1 task done
Madis0 opened this issue Feb 8, 2023 · 3 comments · May be fixed by #122
Open
1 task done

[Feature Request]: Warn on downgrades #80

Madis0 opened this issue Feb 8, 2023 · 3 comments · May be fixed by #122
Labels
enhancement New feature or request important High priority issues
Milestone

Comments

@Madis0
Copy link
Member

Madis0 commented Feb 8, 2023

Code of Conduct

  • I agree to follow this project's Code of Conduct

Potential Enhancement

Vanilla installer should show a big scary warning when attempting to downgrade an instance.

Edit: when mods, config and saves folders are empty or missing, skip this warning.

How it could be implemented

Check if currently installed Minecraft version is newer than the one user wants to install. If yes, show a popup with text, like

You are attempting to downgrade the Minecraft version. This is NOT SUPPORTED by Mojang or Fabulously Optimized and it may cause world corruption or crashes.
If you want to do this safely, you should backup mods, config and saves folders to a different location and delete them from your .minecraft folder.
I agree that downgrades are unsupported by Mojang and Fabulously Optimized, but I want to do this anyway.
Open .minecraft Install anyway*

* button is enabled only when the checkbox is checked

Anything else?

Even something as simple as 1.19.2 -> 1.18.2 currently causes a Zoomify crash, so this is definitely needed.

@Madis0 Madis0 added enhancement New feature or request important High priority issues labels Feb 8, 2023
@osfanbuff63 osfanbuff63 added this to the Beta 3 milestone Feb 8, 2023
@osfanbuff63
Copy link
Member

Should we extend this to stable -> alpha/beta versions of FO as well? Or just downgrading, as that would cause more of a problem?

@Madis0
Copy link
Member Author

Madis0 commented Feb 14, 2023

Good point, that requires a special message too. How about

You are attempting to install an experimental version of Fabulously Optimized. While it is supported, it is currently incomplete and some features may be missing. You may also experience crashes or bugs, please report them to our Discord.
If you want to do this safely, you should backup mods, config and saves folders to a different location and delete them from your .minecraft folder.
I am willing to install this experimental version
Open .minecraft Install anyway*

* button is enabled only when the checkbox is checked

@osfanbuff63 osfanbuff63 linked a pull request Apr 17, 2023 that will close this issue
osfanbuff63 added a commit that referenced this issue Apr 17, 2023
BREAKING CHANGE: The format of the version file has been updated, and it will no longer work with older versions of Vanilla Installer. Fixes #80
@Madis0
Copy link
Member Author

Madis0 commented Apr 21, 2023

Might as well mention that this warning is not needed if the user is using separate instances for FO versions (#61).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request important High priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants