Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make downgrade warnings more detailed #9

Closed
Madis0 opened this issue Jun 1, 2023 · 4 comments
Closed

Make downgrade warnings more detailed #9

Madis0 opened this issue Jun 1, 2023 · 4 comments
Labels
enhancement New feature or request important

Comments

@Madis0
Copy link
Member

Madis0 commented Jun 1, 2023

...and detect when the warning is not needed, aka empty folders as described below
Fabulously-Optimized/vanilla-installer-python#80

@Madis0 Madis0 added enhancement New feature or request important labels Jun 1, 2023
@vgskye
Copy link
Collaborator

vgskye commented Jun 2, 2023

I can do the part described in the title. Just copy the message from python version?
Detecting frivolous warnings however, that's somewhat more involved, as frontend purposefully lacks any direct access to filesystem. Maybe just direct the user to remove paigaldaja_meta.json after moving the folders?

@Madis0
Copy link
Member Author

Madis0 commented Jun 2, 2023

as frontend purposefully lacks any direct access to filesystem

Then a backend check is needed I believe? Without a check I don't see how would it even differ between overwriting .minecraft and having the isolated folder...

Maybe just direct the user to remove paigaldaja_meta.json after moving the folders?

What does that file even do?

@vgskye
Copy link
Collaborator

vgskye commented Jun 2, 2023

paigaldaja_meta.json contains a list of files installed by the installer and whatever metadata frontend provides; frontend reads back the metadata to check if it is a downgrade. If you remove the file, the installer behaves as if it was a fresh install.

@Madis0
Copy link
Member Author

Madis0 commented Jun 2, 2023

Okay, then it could be mentioned in the instructions indeed.

@vgskye vgskye closed this as completed in 866515d Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request important
Projects
None yet
Development

No branches or pull requests

2 participants