You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey guys, had a look through the repo, and firstly, this is amazing for week 11/12 stuff - redux-form especially is something I've never done, but have heard tough things about from very experienced developers, so very impressive you've got that down! 🎉
Genuinely there doesn't appear to be any major improvements you need to make, but I've seen a few things, so will raise a few issues about them (you may already know about them in which case ignore me).
Anyway, first one is simple, and I kinda mentioned it to you last week - would be good to at least have some local install instructions on your README, so someone can check out the repo easily - just setting up the db and the scripts you need to run.
The README really doesn't need to be comprehensive at all, but it'll just be really helpful for anyone new coming across it to have a bit more info on what's going on - example of minimal readme. Also having a good README could be pretty important if you wanted to add this project to a portfolio to show potential employers
The text was updated successfully, but these errors were encountered:
Hey guys, had a look through the repo, and firstly, this is amazing for week 11/12 stuff - redux-form especially is something I've never done, but have heard tough things about from very experienced developers, so very impressive you've got that down! 🎉
Genuinely there doesn't appear to be any major improvements you need to make, but I've seen a few things, so will raise a few issues about them (you may already know about them in which case ignore me).
Anyway, first one is simple, and I kinda mentioned it to you last week - would be good to at least have some local install instructions on your README, so someone can check out the repo easily - just setting up the db and the scripts you need to run.
The README really doesn't need to be comprehensive at all, but it'll just be really helpful for anyone new coming across it to have a bit more info on what's going on - example of minimal readme. Also having a good README could be pretty important if you wanted to add this project to a portfolio to show potential employers
The text was updated successfully, but these errors were encountered: