Incompatible with OpenVPN 2.4.4

[jondkelley]

This may just be an issue with the makescript, or issues with something in code.
openvpn-devel and gcc packages were available on this system before running make.

Environment:
OpenVpn 2.4.4
Centos 7

gcc -std=c99 -Wall -Wextra -Wformat-security -fstack-protector-strong -D_FORTIFY_SOURCE=2 -fPIC -shared -I. -c auth_script.c
In file included from /usr/include/errno.h:28:0,
                 from auth_script.c:18:
/usr/include/features.h:330:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
 #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
    ^
auth_script.c: In function ‘handle_sigchld’:
auth_script.c:39:3: warning: implicit declaration of function ‘waitpid’ [-Wimplicit-function-declaration]
   while(waitpid((pid_t)(-1), 0, WNOHANG) > 0) {}
   ^
auth_script.c:39:18: error: ‘pid_t’ undeclared (first use in this function)
   while(waitpid((pid_t)(-1), 0, WNOHANG) > 0) {}
                  ^
auth_script.c:39:18: note: each undeclared identifier is reported only once for each function it appears in
auth_script.c:39:33: error: ‘WNOHANG’ undeclared (first use in this function)
   while(waitpid((pid_t)(-1), 0, WNOHANG) > 0) {}
                                 ^
auth_script.c: In function ‘deferred_handler’:
auth_script.c:50:20: error: storage size of ‘sa’ isn’t known
   struct sigaction sa;
                    ^
auth_script.c:51:3: warning: implicit declaration of function ‘strdup’ [-Wimplicit-function-declaration]
   char *script_path = strdup(context->script_path);
   ^
auth_script.c:51:23: warning: initialization makes pointer from integer without a cast [enabled by default]
   char *script_path = strdup(context->script_path);
                       ^
auth_script.c:57:3: warning: implicit declaration of function ‘sigemptyset’ [-Wimplicit-function-declaration]
   sigemptyset(&sa.sa_mask);
   ^
auth_script.c:58:17: error: ‘SA_RESTART’ undeclared (first use in this function)
   sa.sa_flags = SA_RESTART | SA_NOCLDSTOP;
                 ^
auth_script.c:58:30: error: ‘SA_NOCLDSTOP’ undeclared (first use in this function)
   sa.sa_flags = SA_RESTART | SA_NOCLDSTOP;
                              ^
auth_script.c:60:3: warning: implicit declaration of function ‘sigaction’ [-Wimplicit-function-declaration]
   if (sigaction(SIGCHLD, &sa, 0) == -1) {
   ^
auth_script.c:50:20: warning: unused variable ‘sa’ [-Wunused-variable]
   struct sigaction sa;
                    ^
auth_script.c: In function ‘openvpn_plugin_open_v3’:
auth_script.c:175:26: warning: assignment makes pointer from integer without a cast [enabled by default]
     context->script_path = strdup(arguments->argv[1]);
                          ^
make: *** [plugin] Error 1

[jondkelley]

#5 suggests people are fixing it