Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sql query error on GetJobs #48

Closed
muhammetustaoglu opened this issue Apr 26, 2022 · 11 comments
Closed

Sql query error on GetJobs #48

muhammetustaoglu opened this issue Apr 26, 2022 · 11 comments

Comments

@muhammetustaoglu
Copy link

In the query, one field in the join statement is "id" instead of "Id". This cause application error

@erwin-faceit
Copy link
Contributor

With what type of database? I’ve not seen this error before.

@muhammetustaoglu
Copy link
Author

We try this on MS Sql Server.

@muhammetustaoglu
Copy link
Author

SqlTagsServiceStorage.cs page line 104 and 205. Can you fix the lines and create new version please? We would like to use this nuget package. Besides, hangfire version is also a little bit old. May be you can update it either.

@erwin-faceit
Copy link
Contributor

We use this on MSSql in production for a few years now. What is the database collation used? If that contains CS, can you change that to CI?

@muhammetustaoglu
Copy link
Author

muhammetustaoglu commented Apr 26, 2022

Our database collation is "Turkish_CI_AS", so im sorry but it is already case insensitive

@erwin-faceit
Copy link
Contributor

I’ll try to create a reproduction of this issue, but am on holiday this week.

@erwin-faceit
Copy link
Contributor

I’m a bit surprised though:

The way to determine if a database or database object is to check its "COLLATION" property and look for "CI" or "CS" in the result. The CI indicates that the server is case insensitive.

@muhammetustaoglu
Copy link
Author

It's ok. I have no rush. I'll create a PR. Review it when you have time. Btw, nice feature. Congrats!

@muhammetustaoglu
Copy link
Author

Since i'm not authorized, i cant create PR. :(

@muhammetustaoglu
Copy link
Author

Hello,
Did you have chance to debug the issue?

@erwin-faceit
Copy link
Contributor

Sorry for the late reaction to this, caught up in regular work. I've just pushed an update of the components.

About updating the Hangfire version: usually packages reference the lowest possible version to maintain compatibility with older projects. You're free to use a higher version though, it should give no problems whatsoever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants