Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 13 FBRetainCycleDetector crash when open Guided Access #81

Closed
CmST0us opened this issue Aug 8, 2019 · 8 comments
Closed

iOS 13 FBRetainCycleDetector crash when open Guided Access #81

CmST0us opened this issue Aug 8, 2019 · 8 comments

Comments

@CmST0us
Copy link

CmST0us commented Aug 8, 2019

In iOS 13, when I turn on Guided Access switch in Accessibility (just turn on the switch, not enter Guided Access in app), the FBRetainCycleDetector will crash in starting time.
It's easy to reappear.

@youngdfb
Copy link
Contributor

youngdfb commented Aug 8, 2019

Could you let us know which iPhone you were using? And also which beta version of iOS 13 (it seems that beta 6 launch today or yesterday)?

@CmST0us
Copy link
Author

CmST0us commented Aug 9, 2019

Could you let us know which iPhone you were using? And also which beta version of iOS 13 (it seems that beta 6 launch today or yesterday)?

My device is iPhone XR, and I just tested in iOS 13 beta6, it crashed again!

@youngdfb
Copy link
Contributor

youngdfb commented Aug 9, 2019

Thanks for the update! Just wanted to be sure it wasn't an old beta version. We will attempt to replicate this on our side.
Turning on the same accessibility option in iOS 12 didn't cause this?
Also, does this only reproduce on a device running iOS 13 or have you managed it with the next XCode beta (of which beta 5 is the latest when I checked yesterday)

@CmST0us
Copy link
Author

CmST0us commented Aug 10, 2019

Thanks for the update! Just wanted to be sure it wasn't an old beta version. We will attempt to replicate this on our side.
Turning on the same accessibility option in iOS 12 didn't cause this?
Also, does this only reproduce on a device running iOS 13 or have you managed it with the next XCode beta (of which beta 5 is the latest when I checked yesterday)

Thanks!
I have try in iOS12.4, it didn't crash. It looks like this problem only happen in iOS 13. And I build my app with Xcode 11 beta5.
BTW: I use Debug building configuration.

@youngdfb
Copy link
Contributor

Thanks for all the information! After we can repro or get a fix, we will let you know

@youngdfb
Copy link
Contributor

There has been a commit synced from Facebook's Fishhook repository: c3d5fb9
This was an issue specific to iOS 13. Could you please pull the latest and let us know if your issue is resolved? Thanks!

@CmST0us
Copy link
Author

CmST0us commented Aug 22, 2019

There has been a commit synced from Facebook's Fishhook repository: c3d5fb9
This was an issue specific to iOS 13. Could you please pull the latest and let us know if your issue is resolved? Thanks!

YES! It works!
Thank you very much!

@CmST0us CmST0us closed this as completed Aug 22, 2019
@ThaiLanKing
Copy link

ThaiLanKing commented Sep 26, 2019

It happend on iPhone XR(iOS13.1),anohter iPhoneX(iOS13.1) is OK,and crash here:indirect_symbol_bindings[i] = cur->rebindings[j].replacement;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants