Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup errors in the library #102

Closed
slawlor opened this issue Dec 8, 2021 · 1 comment · Fixed by #117
Closed

Cleanup errors in the library #102

slawlor opened this issue Dec 8, 2021 · 1 comment · Fixed by #117
Assignees
@eozturk1
Labels
good first issue Good for newcomers optimization

Comments

@slawlor
Copy link
Contributor

slawlor commented Dec 8, 2021

There's a lot of error codes in the errors.rs library which are incorrectly utilized or not utilized at all. These codes should be cleaned up to only what's necessary and not duplicated in multiple structures.
@slawlor
Copy link
Contributor Author

slawlor commented Dec 8, 2021

Additionally, should storage-layer errors be promoted to first-class errors within AkdError?

Other points

  • AkdError should implement fmt::Display
  • Directory::get_current_azks should not return a direct StorageError but a higher AkdError

@eozturk1 eozturk1 self-assigned this Dec 9, 2021
@slawlor slawlor linked a pull request Dec 20, 2021 that will close this issue
Error cleanup #117
Merged
@slawlor slawlor closed this as completed Dec 20, 2021
@slawlor slawlor mentioned this issue Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eozturk1 eozturk1

Labels
good first issue Good for newcomers optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error cleanup
2 participants
@eozturk1 @slawlor