Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifying code #35

Closed
2 tasks done
Jasleen1 opened this issue Aug 17, 2021 · 2 comments
Closed
2 tasks done

Simplifying code #35

Jasleen1 opened this issue Aug 17, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Jasleen1
Copy link
Contributor

Jasleen1 commented Aug 17, 2021 •
edited by slawlor

The code in history_tree_node.rs and append_only_zks.rs can be further simplified. A few suggestions:

  • Remove any remaining instances of unwrap().
  • Look for repeated code among conditionals and abstract it out into a separate function.
@Jasleen1 Jasleen1 added the enhancement New feature or request label Aug 17, 2021
@kevinlewi
Copy link
Contributor

I believe this is almost done, except that we also need to get rid of all sources of panic, such as assert

@kevinlewi kevinlewi removed their assignment Dec 9, 2021
@Jasleen1
Copy link
Contributor Author

I believe this is almost done, except that we also need to get rid of all sources of panic, such as assert

I looked for assert statements and it seems now we only have asserts in test cases. We could likely close this issue.

@slawlor slawlor closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevinlewi @Jasleen1 @slawlor