Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused epoch parameter in append_only_zks::get_membership_proof #364

Closed
kevinlewi opened this issue May 12, 2023 · 0 comments
Closed

Unused epoch parameter in append_only_zks::get_membership_proof #364

kevinlewi opened this issue May 12, 2023 · 0 comments
Assignees
@divyatalesra-2001
Labels
cleanup Changes that don't really affect the core computation, but improve maintenance

Comments

@kevinlewi
Copy link
Contributor

akd/akd/src/append_only_zks.rs

Line 684 in c88f234

_epoch: u64,

Remove the extraneous epoch parameter which is already unused
@kevinlewi kevinlewi added the cleanup Changes that don't really affect the core computation, but improve maintenance label May 12, 2023
@divyatalesra-2001 divyatalesra-2001 self-assigned this May 30, 2023
@divyatalesra-2001 divyatalesra-2001 mentioned this issue May 30, 2023
Merged
divyatalesra-2001 pushed a commit to divyatalesra-2001/akd that referenced this issue May 30, 2023
Cleaning up unused epoch parameter (facebook#364)
e7ef191
divyatalesra-2001 added a commit that referenced this issue May 30, 2023
@divyatalesra-2001
Cleaning up unused epoch parameter (#364) (#370)
f462c43 
Co-authored-by: Divya Talesra <divyatalesra@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@divyatalesra-2001 divyatalesra-2001

Labels
cleanup Changes that don't really affect the core computation, but improve maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinlewi @divyatalesra-2001