Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename public-tests to public_tests #374

Closed
kevinlewi opened this issue Jun 7, 2023 · 1 comment
Closed

Rename public-tests to public_tests #374

kevinlewi opened this issue Jun 7, 2023 · 1 comment
Labels
cleanup Changes that don't really affect the core computation, but improve maintenance

Comments

@kevinlewi
Copy link
Contributor

This feature should be renamed to have an underscore instead of a hyphen, to follow the convention of all of the other features.

Should change all of the places that show up through grep: https://github.com/search?q=repo%3Afacebook%2Fakd%20public-tests&type=code
@kevinlewi kevinlewi added the cleanup Changes that don't really affect the core computation, but improve maintenance label Jun 7, 2023
@kevinlewi
Copy link
Contributor Author

Closed by #379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Changes that don't really affect the core computation, but improve maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinlewi