Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing behavior for NodeLabels and the get_bit_at() function based on label length #398

Closed
kevinlewi opened this issue Aug 31, 2023 · 0 comments · Fixed by #407
Closed

Confusing behavior for NodeLabels and the get_bit_at() function based on label length #398

kevinlewi opened this issue Aug 31, 2023 · 0 comments · Fixed by #407

Comments

@kevinlewi
Copy link
Contributor

  • Hashing NodeLabels will take into account the values past their label length
  • get_bit_at() does not return an error when called on an index beyond label length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding error checks for NodeLabel::try_from() and get_bit_at() error returns kevinlewi/akd
1 participant
@kevinlewi