Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid choice parameter example in the core.md file #91

Closed
Irynei opened this issue May 15, 2019 · 2 comments
Closed

Invalid choice parameter example in the core.md file #91

Irynei opened this issue May 15, 2019 · 2 comments
Assignees
Labels
documentation Additional documentation requested fixready Fix has landed on master.

Comments

@Irynei
Copy link

Irynei commented May 15, 2019

There is a small typo in the example of choice parameters in the core.md document. ChoiceParameter didn't have value param, instead, it is called values.

Currently:

choice_param = ChoiceParameter(name="y", parameter_type=ParameterType.STRING, value=["foo", "bar"])

Should be:

choice_param = ChoiceParameter(name="y", parameter_type=ParameterType.STRING, values=["foo", "bar"])
@kkashin kkashin self-assigned this May 15, 2019
@kkashin kkashin added the documentation Additional documentation requested label May 15, 2019
@kkashin
Copy link
Contributor

kkashin commented May 15, 2019

Thanks for identifying that - will be fixed shortly: #92

@kkashin kkashin added the fixready Fix has landed on master. label May 16, 2019
@ldworkin
Copy link
Contributor

Closing, since this should be in our current release (0.1.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Additional documentation requested fixready Fix has landed on master.
Projects
None yet
Development

No branches or pull requests

3 participants