Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buck2 init --git may not be producing a correct .gitignore #140

Closed
steveklabnik opened this issue Apr 10, 2023 · 2 comments
Closed

buck2 init --git may not be producing a correct .gitignore #140

steveklabnik opened this issue Apr 10, 2023 · 2 comments

Comments

@steveklabnik
Copy link
Contributor

By default, no .gitignore is produced, but I believe that you'd want to produce one for buck-out, because I don't believe (I may be wrong!) that you don't want to include this directory into version control.
@themarwhal
Copy link
Contributor

Yes, that seems like a good default value to put into .gitignore! Thanks for the suggestion.

steveklabnik added a commit to steveklabnik/buck2 that referenced this issue Apr 11, 2023
@steveklabnik
Generate a .gitignore with buck2 init --git
b3e1be4 
This creates a gitignore that will ignore the default output directory.

Fixes facebook#140
@steveklabnik steveklabnik mentioned this issue Apr 11, 2023
Closed
steveklabnik added a commit to steveklabnik/buck2 that referenced this issue Apr 11, 2023
@steveklabnik
Generate a .gitignore with buck2 init --git
2c8c786 
This creates a gitignore that will ignore the default output directory.

Fixes facebook#140
steveklabnik added a commit to steveklabnik/buck2 that referenced this issue Apr 11, 2023
@steveklabnik
Generate a .gitignore with buck2 init --git
bf6644e 
This creates a gitignore that will ignore the default output directory.

Fixes facebook#140
facebook-github-bot pushed a commit that referenced this issue Apr 11, 2023
@themarwhal @facebook-github-bot
init: add buck-out to .gitignore generated by buck2 init --git
18bcd6f 
Summary:
buck-out should be in .gitignore (if it's empty)

see #140

Reviewed By: stepancheg

Differential Revision: D44882336

fbshipit-source-id: e9d46fedf14f57fcc21513c51c075ba00c20d1b2
@ndmitchell
Copy link
Contributor

Done in 18bcd6f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate a .gitignore with buck2 init --git steveklabnik/buck2
3 participants
@steveklabnik @ndmitchell @themarwhal