Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong "Running" value in terminal UI #251

Open
sluongng opened this issue May 12, 2023 · 1 comment
Open

Wrong "Running" value in terminal UI #251

sluongng opened this issue May 12, 2023 · 1 comment

Comments

@sluongng
Copy link
Contributor

> buck2 build -c build.threads=2 //...
Build ID: 0066ddac-5227-49b1-803b-7342c428db71
Command: build.                                                        Jobs: Running: 2.0 K. Progress: 8.1 K/12 K. Cache hits: 0%. Time elapsed: 25.1s
------------------------------------------------------------------------------------------------------------------------------------------------------
root//:x_250 -- action (genrule) [local_execute 1.6s]                                                                                            24.2s
root//:x_291 -- action (genrule) [local_execute 1.6s]                                                                                            24.2s
root//:x_301 -- action (genrule) [local_queued]                                                                                                  24.2s
root//:x_294 -- action (genrule) [local_queued]                                                                                                  24.2s
root//:x_289 -- action (genrule) [local_queued]                                                                                                  24.2s
root//:x_253 -- action (genrule) [local_queued]                                                                                                  24.2s
root//:x_260 -- action (genrule) [local_queued]                                                                                                  24.2s
root//:x_264 -- action (genrule) [local_queued]                                                                                                  24.2s
root//:x_26 -- action (genrule) [local_queued]                                                                                                   24.2s
root//:x_278 -- action (genrule) [local_queued]                                                                                                  24.2s
root//:y_650 -- action (genrule) [local_queued]                                                                                                  24.2s
root//:x_279 -- action (genrule) [local_queued]                                                                                                  24.2s
root//:x_283 -- action (genrule) [local_queued]                                                                                                  24.2s
root//:x_29 -- action (genrule) [local_queued]                                                                                                   24.2s
root//:x_165 -- action (genrule) [local_queued]                                                                                                  24.2s
root//:x_3 -- action (genrule) [local_queued]                                                                                                    24.2s
root//:y_78 -- action (genrule) [local_queued]                                                                                                   24.2s
root//:x_246 -- action (genrule) [local_queued]                                                                                                  24.2s
root//:x_272 -- action (genrule) [local_queued]                                                                                                  24.2s
... and 3964 more

Even when we limit threads to a very small amount (2 like the command above), the terminal UI was still reporting Jobs: Running: 2.0 K., which is wrong.

This should be fixed to Jobs: Scheduled: 2.0 K. Running: 2 instead.

This could also be applied to RBE where scheduling and executing could be 2 separate statuses.

@krallin
Copy link
Contributor

krallin commented May 12, 2023

Ah, "Jobs" there doesn't actually mean "commands" (look at analysis earlier in the build for example, that counts as running, the same is true of the progress counter).

We can probably rename this to something else, e.g. "Active"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants