Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fb_systemd::udevd fails on Ubuntu 20.04 LTS due to missing symlink #123

Closed
ChefAustin opened this issue May 1, 2020 · 1 comment
Closed

Comments

@ChefAustin
Copy link
Contributor

On Ubuntu 16 and 18 the fb_systemd::udevd recipe succeeds without issue but on Ubuntu 20 the recipe will fail because the symlink from /sbin/udevadm to /bin/udevadm has been removed.

From the udev filelists provided by Canonical for each release, one can validate the existence of /sbin/udevadm in Xenial and Bionic Beaver, as well as its non-existence on Focal Fossa.

facebook-github-bot pushed a commit that referenced this issue May 5, 2020
Summary:

This pull request, if merged, will change `fb_systemd::udevd` ever-so-slightly by adding a symlink from `/sbin/udevadm` to `/bin/udevadm` at the beginning of the recipe.

The symlink creation is needed to mitigate an issue (#123) that is displayed when this recipe is run on Ubuntu 20 whereby the recipe fails due to Canonical's removal of the `/sbin/udevadm` symlink. By re-adding the symlink back to the system at the beginning of this recipe, it should ensure that the subsequent `trigger udev`, `reload udev`, and `update hwdb` `execute` resources proceed without path existence errors.

I considered a couple different alternative approaches to this fix but ultimately thought this was the most sane means of fixing this. Please feel free to dissent if you feel this approach is unsafe or not the best way to go about this.
Pull Request resolved: #124

Reviewed By: nikitakoshikov

Differential Revision: D21406169

Pulled By: davide125

fbshipit-source-id: 9a98ee02a019b95fb73188232afa2d1e1014a884
@malmond77
Copy link
Contributor

The PR is merged, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants