Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fb_network_scripts changes should be reflected in /var/chef/backup #155

Open
davide125 opened this issue Oct 8, 2020 · 1 comment
Open

Comments

@davide125
Copy link
Member

fb_network_scripts does some trickery under the hood to in-place modify configs to try and avoid network restarts at much as possible. This is great, but the changes don't get reflected in /var/chef/backups, making troubleshooting harder at times. I'm not entirely sure if this is something we can sanely improve, but filing this for tracking and visibility.

@jaymzh
Copy link
Collaborator

jaymzh commented Oct 8, 2020

There's some ways to make this better.

That said I'd be careful... there are two different times when we write to that file - one is to mask "cosmetic" changes - the other is because we are going to implement the change ourselves and don't want to trigger a full interface bounce. It may make sense to only "backup" the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants