Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install instructions from brew misses information #37

Closed
pbernery opened this issue Mar 31, 2014 · 5 comments · Fixed by #38
Closed

Install instructions from brew misses information #37

pbernery opened this issue Mar 31, 2014 · 5 comments · Fixed by #38

Comments

@pbernery
Copy link

Installation misses instructions when installing from brew and, I guess, when you use python from OS X, not the one installed with brew. I had to manually add this command to ~/.lldbinit:

command script import /usr/local/Cellar/chisel/1.0.0/libexec/fblldb.py

while the instructions suggest that it is needed only when installing manually.

@dstnbrkr
Copy link
Contributor

Both the homebrew recipe doesn't add this line to ~/.lldbinit either (both manual and brew installs require it to be added manually).

I would prefer it if the brew recipe did add this line, but hesitant to modify a user's dotfiles from a homebrew recipe.

Still, good to know you had the expectation that it would modify ~/.lldbinit - so maybe I'll take another look at this.

@pbernery
Copy link
Author

I didn't really expect brew install to modify my conf file though I expected to have it work as soon as brew install was finished.

I think an update of the install instructions would be enough. As I mentioned, it suggests that editing the ~/.lldbinit is only needed when installing manually while is is required for both methods.

I just saw that brew info chisel gives information about that, in the Caveats section. This info could also be displayed at install time (I don't it has been displayed).

@dstnbrkr
Copy link
Contributor

Yep, the caveats are displayed at the end of installation.

@pbernery
Copy link
Author

Correct, I missed it.

@dstnbrkr
Copy link
Contributor

I see what you mean in the README, will clarify that in either case there's a manual step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants