Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an umbrella header? #46

Closed
kastiglione opened this issue Mar 30, 2015 · 5 comments
Closed

Create an umbrella header? #46

kastiglione opened this issue Mar 30, 2015 · 5 comments

Comments

@kastiglione
Copy link
Contributor

Is the absence of an umbrella header an oversight, or part of the framework's opinions?

@adamjernst
Copy link
Contributor

Opinions. I dislike umbrella headers generally. (Probably influenced by the fact that we dislike them at Facebook generally...)

@jlpiedrahita
Copy link
Contributor

Most system frameworks and 3rd party libraries/frameworks do it.

Can you expand on why you think this should not be done? Personally I find it annoying to have to know which file to include for each symbol I need, it's not always obvious.

@adamjernst adamjernst reopened this Apr 6, 2015
@adamjernst
Copy link
Contributor

Well, I wouldn't be opposed to a pull request I guess. We can always disallow its use internally.

(With the sheer amount of code we have, we find umbrella headers end up bloating compilation times and result in huge numbers of symbols available. But for most smaller projects it's not an issue at all.)

@kastiglione
Copy link
Contributor Author

👍 I like giving the option, particularly since they're very conventional.

@kastiglione
Copy link
Contributor Author

This relates to #44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants