-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an umbrella header? #46
Comments
Opinions. I dislike umbrella headers generally. (Probably influenced by the fact that we dislike them at Facebook generally...) |
Most system frameworks and 3rd party libraries/frameworks do it. Can you expand on why you think this should not be done? Personally I find it annoying to have to know which file to include for each symbol I need, it's not always obvious. |
Well, I wouldn't be opposed to a pull request I guess. We can always disallow its use internally. (With the sheer amount of code we have, we find umbrella headers end up bloating compilation times and result in huge numbers of symbols available. But for most smaller projects it's not an issue at all.) |
👍 I like giving the option, particularly since they're very conventional. |
This relates to #44. |
Is the absence of an umbrella header an oversight, or part of the framework's opinions?
The text was updated successfully, but these errors were encountered: