Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation mismatch between CKComponent and quick start guide #78

Closed
avnerbarr opened this issue Apr 8, 2015 · 1 comment
Closed

Comments

@avnerbarr
Copy link
Contributor

In the documentation under "state"
http://componentkit.org/docs/state.html

The described method of changing state implies calling a method on CKComponent which isn't exposed in the .h file

@interface CKComponent
- (void)updateState:(id (^)(id))updateBlock; // not in .h file of CKComponent - compiler error . I manually added it to my class , get a "not implemented" warning but it works .
@end

The documentation should also explain adding the CKComponentActionAttribute or another method of getting the callback

@adamjernst
Copy link
Contributor

updateState: is exposed in CKComponentSubclass.h.

Thanks for the feedback though — I agree it's not entirely clear. I'd love a pull request to fix it if you have the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants