Ejecting should keep .babelrc treated as root

[gaearon]

Not sure there's an easy way to fix it but I think that after we eject and generate babel config in package.json it may start looking for more configs in parent folders (which it doesn't do now thanks to this).

If my understanding is correct this might "break" projects on ejecting if there are .babelrc in parent folders.

Help wanted: confirm whether it's an issue, and if it is, propose a fix.

[anilreddykatta]

@gaearon If the project already has a .babelrc with different presets which one do you think should take preference?

[gaearon]

It is not supported to have .babelrc before ejecting.
I think ejecting should fail if you already have one.

[anilreddykatta]

@gaearon Currently, we fail ejecting if we have .babelrc at project root?

[BrodaNoel]

@gaearon any clue about it? I can work on it if you give me the first clue about where I should start.

[gaearon]

Any clue about what specifically?

[gustavogodoi]

PR #3803 opened to try to add this validation.

[viankakrisna]

eslint has root: true to tell it to stop searching for config in parent folder https://eslint.org/docs/user-guide/configuring#using-configuration-files i think we can port the feature to babel?

edit: related discussion: babel/babel#6766

[gustavogodoi]

Maybe we could use loader-utils to check the babel config. loaderUtils.getOptions(this).babelrc should get the config.

e.g. from babel-loader:
https://github.com/babel/babel-loader/blob/master/src/index.js#L113

[loganfsmyth]

Babel will stop searching up the directory hierarchy when it encounters:

• A directory containing a .babelrc
• A directory containing a package.json that contains a babel field.

I believe that means this should be fine as long as you create the .babelrc. As mentioned above, with babel/babel#6766 we may also add a concept of a root to Babel which would not search above the given root, among other things.

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs.