-
-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images with non-ascii names don't appear in dev mode #1396
Comments
Thanks for reporting. Likely a bug in Webpack. |
Tagging as 0.9.1—not because we'll fix it, but because we should at least report it upstream to the project causing it, whether Webpack or something else. Once we report it I'm happy to untag it. |
We'll have to test if webpack 2 fixes this. |
@vgrigoriu can you test if |
Can you point me at instructions on how to use |
You can clone the project, run npm install and npm start. This will run the development server with the default template. You can then edit it in packages/react-scripts/template. |
Thanks, I'll give it a try and let you know. |
It seems to have exactly the same behavior as before. The img with diacritics generates a url like http://localhost:3000/static/media/P%C3%A9tiole.f885429e.jpg, but the development server returns the home page for it. |
Would you like to help us by filing a bug in Webpack? |
We can ping @bebraw if he's not too busy and ask if he has a suggestion or reason for this (he cut the last release for |
Hi, I forwarded this to @SpaceK33z as he knows more about WDS. It might be something there. |
Should I still open the bug in Webpack? |
Maybe better wait for @SpaceK33z to comment, but do as you want. 👍 |
Just a note that I haven't forgotten this, it's on my list to research soon. It's probably a bug in webpack-dev-middleware. |
Okay, found the issue in webpack-dev-middleware and released a new version. Thanks @vgrigoriu for providing a repository, that really helped with narrowing down the issue quickly (I wish everyone would do that 😄 ). |
Since this is a transitive dependency, I’m guessing we can close this. New installs shouldn’t have this problem. |
@vgrigoriu Thanks for reporting. |
I confirmed that it is indeed fixed with webpack-dev-middleware 1.10.1. Thanks everyone for your help. |
Can you reproduce the problem with latest npm?
Yes.
Description
In dev mode, images in src which are imported and have non-ascii characters in their names are not loaded. The problem does not appear in production builds
Expected behavior
Tell us what you think should happen.
Actual behavior
Tell us what actually happens.
Environment
Run these commands in the project folder and fill in their results:
npm ls react-scripts
(if you haven’t ejected):react-scripts@0.8.5
node -v
:v7.1.0
npm -v
:4.0.2
Then, specify:
Reproducible Demo
https://github.com/vgrigoriu/diacriticsInFilenames/
Just
yarn start
to see the issue. There are two identical images, one namedPetiole.jpg
(which works just fine) and one namedPétiole.jpg
which doesn't load. I noticed that this doesn't happen for smaller images, which are converted to data urls.The text was updated successfully, but these errors were encountered: