Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add backstroke-bot with read permission to the repo #1545

Closed
thtliife opened this issue Feb 12, 2017 · 17 comments
Closed

Please add backstroke-bot with read permission to the repo #1545

thtliife opened this issue Feb 12, 2017 · 17 comments

Comments

@thtliife
Copy link

As per: backstrokeapp/server#27
When forking cra in order to maintain a custom --scripts-version, using backstroke to keep the fork updated against this repo is very convenient.
This is not possible if backstroke-bot does not have read access...

@thtliife thtliife changed the title Please add backstroke-bot with read permission to the repo Please add backstroke-bot with read permission to the repo Feb 12, 2017
@Timer
Copy link
Contributor

Timer commented Feb 12, 2017

I'm not sure if that issue applies to us, we're not a private repository

@thtliife
Copy link
Author

I wonder why I am not able to get it working then... ?
@Timer do you know of any repos that have gotten this working?

@Timer
Copy link
Contributor

Timer commented Feb 12, 2017

I do not know of any, sorry. I'm sure they exist somewhere! What sort of error are you getting?

@thtliife
Copy link
Author

thtliife commented Feb 12, 2017

Uhh, error: {"message":"Validation Failed","errors":[{"message":"The listed users and repositories cannot be searched either because the resources do not exist or you do not have permission to view them.","resource":"Search","field":"q","code":"invalid"}],"documentation_url":"https://developer.github.com/v3/search/"}

that is if I try the classic mode, which is not well supported anymore...
when trying to use the standard mode, I get:
No permission to add a webhook to the repository facebookincubator/create-react-app. Make sure thtliife has given Backstroke permission to access this organisation or repo via OAuth.
And obviously, I (@thtliife) am not able to give backstroke permission...

@Timer
Copy link
Contributor

Timer commented Feb 12, 2017

I believe you already found it, but I would try using backstroke classic as described here: #682 (comment).

@Timer
Copy link
Contributor

Timer commented Feb 12, 2017

Are you trying to add backstroke to our repository instead of yours? The error seems to be hinting towards that. Make sure you're using https://github.com/thtliife/create-react-app-storybook-scripts-fork

@thtliife
Copy link
Author

I am trying to add it to my fork...
screen shot 2017-02-13 at 9 10 31 am

@Timer
Copy link
Contributor

Timer commented Feb 12, 2017

After reading the docs, I think those roles should be switched. From should be your repo, To should be create-react-app.

@thtliife
Copy link
Author

would that not try to sync pushes from my repo to cra's?

@Timer
Copy link
Contributor

Timer commented Feb 12, 2017

I'm not sure really, their docs are so confusing. The way you have it pictured is the logical way, but who knows. Once we figure this out we can go ahead and document it for posterity. I'd appreciate if you could do some more research, @thtliife.

@thtliife
Copy link
Author

oh no problems @Timer
Manually refactoring everything from the recent webpack 2 release of cra was painful...
I'll be sure to get this working... and once I have, I'd be happy to make a pr for the doco...

@thtliife
Copy link
Author

In the meantime, I have opened backstrokeapp/server#52 to try to get some clarity...

@thtliife
Copy link
Author

I wonder though, if its something to do with the monorepo setup, and maybe backstroke's handling of such a repo?

@1egoman
Copy link

1egoman commented Feb 13, 2017

@thtliife @Timer I'm the creator of Backstroke.

I left a comment on the issue on the Backstroke repo: backstrokeapp/server#52 (comment)

I'm going to take a look at Backstroke's docs tonight and see what I can do to make them more clear. Any feedback / suggestions would be very helpful.

@thtliife
Copy link
Author

@1egoman @Timer
It looks to be ok now :)
I can successfully create a link on https://backstroke.us
and testing with curl returns

{
	"status": "ok",
	"output": {
		"status": "ok",
		"pullRequest": {
			"msg": "There's already a pull request for this repo, no need to create another."
		},
		"isEnabled": true,
		"many": false,
		"forkCount": 1
	}
}

@Timer
Copy link
Contributor

Timer commented Feb 13, 2017

Perfect, thanks! @thtliife can you please update #779?

@Timer Timer closed this as completed Feb 13, 2017
@thtliife
Copy link
Author

@Timer will do :)

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants