Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up AppVeyor and make end-to-end tests cross-platform #1646

Closed
gaearon opened this issue Feb 26, 2017 · 3 comments
Closed

Set up AppVeyor and make end-to-end tests cross-platform #1646

gaearon opened this issue Feb 26, 2017 · 3 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Feb 26, 2017

We should have a windows CI test suite or we'll keep getting issues like #1645.

I'm not sure how to set it up so would appreciate help.
@Timer
Copy link
Contributor

Timer commented Feb 26, 2017

Lucky for us, AppVeyor executes commands with a cygwin shell unless we explicitly tell it to use PowerShell (ps) or Windows Command Prompt (cmd).

Eventually, I'm sure we'd like to execute these tests directly under CMD (requires quite a bit of work), but for now I think this will be fine.

I'm actually seeing some errors that we need to fix for windows users, will open individual issues.

@Timer
Copy link
Contributor

Timer commented Mar 1, 2017

Good to go!

@Timer Timer closed this as completed Mar 1, 2017
@gaearon
Copy link
Contributor Author

gaearon commented Mar 1, 2017

Thanks!

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Timer @gaearon