Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't call it "My First React App" in the title #16

Closed
lacker opened this issue Jul 18, 2016 · 3 comments
Closed

don't call it "My First React App" in the title #16

lacker opened this issue Jul 18, 2016 · 3 comments
Milestone
0.1.0

Comments

@lacker
Copy link
Contributor

lacker commented Jul 18, 2016

Because we don't want it to only be used by people making their first react app, do we?

How about taking the name from the directory it gets created in.
@gaearon
Copy link
Contributor

gaearon commented Jul 18, 2016

Agreed!

@gaearon gaearon added this to the 0.1.0 milestone Jul 18, 2016
@vjeux
Copy link
Contributor

vjeux commented Jul 18, 2016

b214b17

The index.html file is currently static so it's a bit annoying to make it use the folder name. Feel free to send a diff to update it if you feel like it.

@vjeux vjeux closed this as completed Jul 18, 2016
@mxstbr
Copy link
Contributor

mxstbr commented Jul 18, 2016 •
edited

You can inject that with the HTMLWebpackPlugin from the webpack config I'm pretty sure, be wary though because that'll override whatever the users puts in there themselves.

EDIT: Sorry for the reopen, that was a misclick

@mxstbr mxstbr reopened this Jul 18, 2016
@mxstbr mxstbr closed this as completed Jul 18, 2016
stayradiated pushed a commit to stayradiated/create-react-app that referenced this issue Nov 13, 2016
@stereobooster
Fix for facebook#16 fix eject script
c2a095a
stayradiated pushed a commit to stayradiated/create-react-app that referenced this issue Nov 13, 2016
@kitze
Merge pull request facebook#17 from stereobooster/16-fix-eject
c09c146 
Fix for facebook#16 fix eject script
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
4 participants
@lacker @vjeux @gaearon @mxstbr