Relax anti-label lint rules.

[jannotti]

Description

Lint rules complain about this:

outer:
for (const row of rows) {
  for (const elt of row) {
    if (elt === 0)
     break outer;
    // compute on elt
  }
}

which is the most succinct way to stop processing the current row and all following rows, once a zero is encountered anywhere.

They complain in two ways, first no-restricted-syntax complains about any label of any kind. Then no-labels complains twice, first about the label again, and second about the break statement with a label.

Expected behavior

No complaints. I'd probably be ok with a complaint about this:

label: {
   var a = f();
   if (something())
     break label;
   //etc
}

as that's weird (but apparently legal). However labels are needed on looping constructs for exactly the purpose outlined here.

Actual behavior

Three lint complaints.

[Timer]

I believe we agreed to go forward with this.
Can you please submit a PR removing the rule(s)? Thanks!

[Timer]

@jannotti if you can submit a PR for this, let me know!

[shaunwallace]

@Timer @jannotti I can pick this up otherwise.

[jannotti]

@shaunwallace That would be great. I'm sure it's a one line fix, but I haven't even looked at CRA's source yet.

[Timer]

All yours @shaunwallace.

[Timer]

@shaunwallace Are you still interested in pursuing this? 😄