Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Travis test with empty NODE_PATH #2263

Open
gaearon opened this issue May 19, 2017 · 3 comments
Open

Add Travis test with empty NODE_PATH #2263

gaearon opened this issue May 19, 2017 · 3 comments
Labels
contributions: up for grabs! difficulty: medium tag: internal
Milestone
100.0

Comments

@gaearon
Copy link
Contributor

gaearon commented May 19, 2017

Since Travis tests run with NODE_PATH specified, it doesn't catch issues in code that does something wrong on empty NODE_PATH. We should add end-to-end tests for starting, building, and running tests with empty NODE_PATH.
@gaearon gaearon mentioned this issue May 19, 2017
Merged
@BrodaNoel
Copy link
Contributor

BrodaNoel commented May 23, 2017 •
edited
Loading

This should be tackled in this file, right?

@gaearon
Copy link
Contributor Author

gaearon commented Jan 8, 2018

Yeah.

@stale
Copy link

stale bot commented Nov 2, 2018

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the stale label Nov 2, 2018
@Timer Timer removed the stale label Nov 2, 2018
@Timer Timer added this to the 100.0.0 milestone Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions: up for grabs! difficulty: medium tag: internal
Projects
None yet
Milestone
100.0
Development

No branches or pull requests
3 participants
@Timer @gaearon @BrodaNoel