Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic public path output #232

Closed
oleblaesing opened this issue Jul 27, 2016 · 2 comments
Closed

Dynamic public path output #232

oleblaesing opened this issue Jul 27, 2016 · 2 comments

Comments

@oleblaesing
Copy link

oleblaesing commented Jul 27, 2016

When running npm run build the index.html is compiled with prefixed / for the asset links. node_modules/react-scripts/config/webpack.config.prod.js shows me, that the / is currently hardcoded, but when I read the create-react-app source files (config/webpack.config.prod.js) the prefix is built dynamically. So where does the "hard" prefix come from and how to use the homepage property in my local package.json?

@gaearon
Copy link
Contributor

gaearon commented Jul 27, 2016

So where does the "hard" prefix come from and how to use the homepage property in my local package.json?

From https://github.com/facebookincubator/create-react-app/blob/master/template/README.md#deploy-to-github-pages:

Note: this feature is available with react-scripts@0.2.0 and higher.

0.2.0 has not been released yet. So you can’t do it yet.

@gaearon gaearon closed this as completed Jul 27, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 27, 2016

You can try 0.2.0 alpha now, it handles homepage and contains GH Pages deployment instructions. #190

@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants