-
-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
registerServiceWorker.js unit tests #2929
Labels
Comments
We have no unit tests for that! Would you like to contribute some? |
@Timer I would love to, but not sure if I can work it into the milestones for my current project using react-scripts. If I can get er dun, I'll be submitting a PR! |
Sounds good! I'll be looking forward to any potential work. |
Anyone test this file yet? |
Meh. I don't think this is important and wouldn't spend effort there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi team,
I see that you don't want to exclude the registerServiceWorker.js file from test coverage, which I agree with. However, I love to at least attempt to get full coverage.
With that in mind...do you have the unit tests for this file somewhere? Either partially or completely written? It'd be great to drop those tests in to our repo to get this file at (or near) full coverage.
thank you for any help!
Scott
The text was updated successfully, but these errors were encountered: