Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registerServiceWorker.js unit tests #2929

Closed
scottnath opened this issue Aug 9, 2017 · 5 comments
Closed

registerServiceWorker.js unit tests #2929

scottnath opened this issue Aug 9, 2017 · 5 comments

Comments

@scottnath
Copy link

Hi team,

I see that you don't want to exclude the registerServiceWorker.js file from test coverage, which I agree with. However, I love to at least attempt to get full coverage.

With that in mind...do you have the unit tests for this file somewhere? Either partially or completely written? It'd be great to drop those tests in to our repo to get this file at (or near) full coverage.

thank you for any help!
Scott

@Timer
Copy link
Contributor

Timer commented Aug 9, 2017

We have no unit tests for that! Would you like to contribute some?

@scottnath
Copy link
Author

@Timer I would love to, but not sure if I can work it into the milestones for my current project using react-scripts. If I can get er dun, I'll be submitting a PR!

@Timer
Copy link
Contributor

Timer commented Aug 10, 2017

Sounds good! I'll be looking forward to any potential work.

@timrichd
Copy link

Anyone test this file yet?

@gaearon
Copy link
Contributor

gaearon commented Jan 8, 2018

Meh. I don't think this is important and wouldn't spend effort there.

@gaearon gaearon closed this as completed Jan 8, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants