Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure eslint-loader works in a sensible way in prod #37

Closed
gaearon opened this issue Jul 20, 2016 · 1 comment · May be fixed by saurabharch/create-react-app#2
Closed

Ensure eslint-loader works in a sensible way in prod #37

gaearon opened this issue Jul 20, 2016 · 1 comment · May be fixed by saurabharch/create-react-app#2
Milestone

Comments

@gaearon
Copy link
Contributor

gaearon commented Jul 20, 2016

I haven’t actually checked what it does.
I think we don’t want to fatal on build, but we want to print any errors/warnings.
We also want to make sure it doesn’t include console.log()s with those warnings into prod bundle.

@gaearon gaearon added this to the 0.1.0 milestone Jul 20, 2016
@gaearon
Copy link
Contributor Author

gaearon commented Jul 21, 2016

Currently it is silent about lint warnings during build.
Not a big deal probably. We can enable special lint for build later.

@gaearon gaearon closed this as completed Jul 21, 2016
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant