Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider whether it's safe to rely on recent Uglify versions #4329

Closed
gaearon opened this issue Apr 20, 2018 · 4 comments
Closed

Reconsider whether it's safe to rely on recent Uglify versions #4329

gaearon opened this issue Apr 20, 2018 · 4 comments
Milestone
2.0

Comments

@gaearon
Copy link
Contributor

gaearon commented Apr 20, 2018

I don't have all the context but just flagging to look at this before cutting 2.x.

https://mobile.twitter.com/AdamRackis/status/987346564527116288
facebook/react#12555 (comment)
facebook/react#12434
@gaearon gaearon added this to the 2.0.0 milestone Apr 20, 2018
@Timer
Copy link
Contributor

Timer commented Apr 21, 2018 •
edited
Loading

Unfortunately, babel-minify is really slow: neutrinojs/neutrino#809 (comment).

@gaearon
Copy link
Contributor Author

gaearon commented Apr 21, 2018

I’d be cautious with that too because we couldn’t get it to work reliably enough at FB about a year ago.

@eliperelman
Copy link
Contributor

Other than build times, babel minify hasn't been too bad. I have been bit before by variable name mangling though, which was painful to debug. We are in a tough period right now with both Uglify and Babel minify not receiving the maintenance love they probably need.

@Timer Timer mentioned this issue Sep 18, 2018
Closed
@Timer
Copy link
Contributor

Timer commented Sep 18, 2018

We've switched to Terser.

@Timer Timer closed this as completed Sep 18, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@eliperelman @Timer @gaearon