Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo .env files #4654

Closed
Andarist opened this issue Jun 20, 2018 · 5 comments
Closed

Monorepo .env files #4654

Andarist opened this issue Jun 20, 2018 · 5 comments

Comments

@Andarist
Copy link
Contributor

Is this a bug report?

No.

Feature request

I see CRA got a nice monorepo support - 1 piece is imho missing though. It would be valuable to read .env files per each monorepo-ed package and apply those read variables within scope of the package.

At the moment app's directory has to hold all env vars from all other directories which doesn't scale well.

@miraage
Copy link

miraage commented Jun 20, 2018

At the moment app's directory has to hold all env vars from all other directories which doesn't scale well.

Could you please explain has to hold all env vars from all other directories? What all other directories?

@Andarist
Copy link
Contributor Author

All other monorepo-ed directories that it can import. They could be "normal" packages - like i.e. some component library, but they could also be other sub-apps.

Imagine this

.                      
└── packages                 
    ├── main-app 
    │   └── .env
    ├── sub-app-a       
    │   └── .env
    └── sub-app-b       
        └── .env

@stale
Copy link

stale bot commented Nov 2, 2018

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the stale label Nov 2, 2018
@Andarist
Copy link
Contributor Author

Andarist commented Nov 2, 2018

The issue is still relevant if you want to support monorepos.

@stale stale bot removed the stale label Nov 2, 2018
@Timer
Copy link
Contributor

Timer commented Nov 2, 2018

We dropped monorepo support and do not plan on adding it back. Thanks!

@Timer Timer closed this as completed Nov 2, 2018
@lock lock bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants