Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update svgr/webpack loader #4799

Closed
wants to merge 1 commit into from
Closed

feat: update svgr/webpack loader #4799

wants to merge 1 commit into from

Conversation

tk-o
Copy link

@tk-o tk-o commented Jul 20, 2018

This PR replaces svgr/webpack loader with its latest version available in @svgr/webpack package.
The change solves #4798.

I tested this code change locally and it now reads custom config from i.e. .svgorc.json file (placed in the project root directory).

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@bugzpodder bugzpodder added this to the 2.0.0 milestone Jul 20, 2018
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gregberge
Copy link

Upgrading to SVGR 2 should reduce dependency size. It is a major including a lot of breaking changes (especially the support of runtime configurations). That's why I think upgrading it before releasing create-react-app 2.0 is very important.

@Timer
Copy link
Contributor

Timer commented Sep 21, 2018

This is waiting on gregberge/svgr#179

@Timer
Copy link
Contributor

Timer commented Sep 21, 2018

Also, we need to disable prettier.

@Timer
Copy link
Contributor

Timer commented Sep 21, 2018

See #5062, thanks for your contribution @kopacki! I'll be sure to mention you in the release notes. 😄

@Timer Timer closed this Sep 21, 2018
@gregberge
Copy link

There is one more thing. SVGR latest requires the latest version of JSDOM, but it could work with the previous one. We should check if bundle size is not impacted by two versions of JSDOM (one for Jest and one for SVGR).

@gregberge
Copy link

SVGR v3 is out! You can now set runtimeConfig: false if you don't want to rely on it! More information -> https://github.com/smooth-code/svgr/releases/tag/v3.0.0

@Timer
Copy link
Contributor

Timer commented Oct 1, 2018

Neat, @neoziro! Thanks for the update.

It'd be really neat if the packages handling configuration, optimizing, and prettifying svgs could be decoupled from the main package so we're not bloating the dependency tree.

@gregberge
Copy link

@Timer I think it is already decoupled enough, "@svgr/core", "@svgr/cli", "@svgr/webpack"... I will not decouple it more.

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants