Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate concept of rewiring config as an alternative of ejecting or forking react-scripts #4970

Closed
AndyOGo opened this issue Sep 5, 2018 · 5 comments

Comments

@AndyOGo
Copy link

AndyOGo commented Sep 5, 2018

Is this a bug report?

(write your answer here)

No

First thank you for this awesome master piece, I really appreciate that work.

Though would like to ask you to incorporate the concept of rewiring config as promoted in:
https://github.com/timarney/react-app-rewired
(Unfortunately it's not maintained anymore)

For details please see here:
https://github.com/timarney/react-app-rewired#how-to-rewire-your-create-react-app-project

This way it would be super easy to add custom loaders for SASS, TypeScript, Inline SVGs, etc.

Related #99

@Timer
Copy link
Contributor

Timer commented Sep 5, 2018

See reply in timarney/react-app-rewired#162 (comment). Thanks!

Once a consensus is met, a proposal issue with most-common use cases would be great!

@Timer Timer closed this as completed Sep 5, 2018
@AndyOGo
Copy link
Author

AndyOGo commented Sep 5, 2018

@Timer
Thank you for your quick answers.

Though I regret that this issue got closed that fast.
Is it really put in stone not adding rewiring?
I agree that it will produce all kinds off side effects, though I think it would be very beneficial on the other side too.

May I kindly ask to reopen this issue and see if it's of interest for the community at all?

@Timer
Copy link
Contributor

Timer commented Sep 5, 2018

I feel that this is a conversation best had in timarney/react-app-rewired#162 because that's where the community's home is. We really want to accommodate the 90% use cases.

At current time, we can say pretty confidently that this decision of not adding rewiring is "set in stone"; we can probably revisit this in about a year, give or take.

Thank you for bringing this to our attention!

@AndyOGo
Copy link
Author

AndyOGo commented Sep 5, 2018

I see, you have already made a firm decision in this regard.

Actually I would love to have this conversation here, inside the official repo.
May I asked you how you get to the data of 90% use cases? Do you have surveys?
If so I would definitely like to participate 😄

@onionhammer
Copy link

onionhammer commented Sep 29, 2018

This is definitely something that's important. Ejecting seems like such an unnecessary thing when its so easy to add in a 'rewire' hook into react-scripts - if FB wanted to do it.

@lock lock bot locked and limited conversation to collaborators Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants