Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annoying warnings #5138

Closed
Timer opened this issue Sep 27, 2018 · 4 comments
Closed

Annoying warnings #5138

Timer opened this issue Sep 27, 2018 · 4 comments

Comments

@Timer
Copy link
Contributor

Timer commented Sep 27, 2018

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
{ Error: EPIPE: broken pipe, write errno: -32, code: 'EPIPE', syscall: 'write' }
{ Error: EPIPE: broken pipe, write errno: -32, code: 'EPIPE', syscall: 'write' }
{ Error: EPIPE: broken pipe, write errno: -32, code: 'EPIPE', syscall: 'write' }
{ Error: EPIPE: broken pipe, write errno: -32, code: 'EPIPE', syscall: 'write' }
joes-mbp:test-next joe$ { Error: EPIPE: broken pipe, write errno: -32, code: 'EPIPE', syscall: 'write'}
{ Error: EPIPE: broken pipe, write errno: -32, code: 'EPIPE', syscall: 'write' }
{ Error: EPIPE: broken pipe, write errno: -32, code: 'EPIPE', syscall: 'write' }

Where did these come from?

@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2018

Which command?

@Timer
Copy link
Contributor Author

Timer commented Sep 27, 2018

yarn build, I suspect this is workers from thread-loader dying off

@Timer
Copy link
Contributor Author

Timer commented Sep 29, 2018

Warm cache:
Thread loader disabled: Done in 33.35s.
Thread loader enabled: ✨ Done in 31.10s.

Cold:
Thread loader disabled: Done in 71.03s.
Thread loader enabled: ✨ Done in 59.11s

We can probably turn this off TBH, webpack 4 is pretty fast. The gains were way more impressive with webpack 3. I think we could find some low-hanging fruit to optimize in webpack/our toolchain.

thread-loader prob isn't maintained enough to be worth this burden overhead and super complicated webpack message parsing.

@gaearon
Copy link
Contributor

gaearon commented Sep 29, 2018

I’m cool with this. And I think ideally we’d want to build on top of jest-worker instead because we know it’s solid and well-maintained. Actually might be worth a try taking thread-loader and rewriting to work on top of that.

@lock lock bot locked and limited conversation to collaborators Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants