Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure @types/jest is the correct version #5595

Open
2 tasks
Timer opened this issue Oct 28, 2018 · 1 comment
Open
2 tasks

Ensure @types/jest is the correct version #5595

Timer opened this issue Oct 28, 2018 · 1 comment
Labels
issue: typescript tag: enhancement
Milestone
5.x

Comments

@Timer
Copy link
Contributor

Timer commented Oct 28, 2018 •
edited

Right now, we always install the latest @types/jest. This is OK since we match the current latest Jest version, but sometimes we lag.

We should:

  1. Add a preflight check for this
  2. Somehow make create-react-app install the correct version for a given react-scripts version
@Timer Timer modified the milestones: 2.1, 2.1.x Oct 28, 2018
@iansu iansu modified the milestones: 2.1.x, 3.x Mar 10, 2019
@awaseem
Copy link
Contributor

awaseem commented Oct 22, 2019

@Timer if you wouldn't, I would love to work on this enhancement. I've seen the TypeScript templating code in the past and have an idea where to start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: typescript tag: enhancement
Projects
None yet
Milestone
5.x
Development

No branches or pull requests
3 participants
@iansu @Timer @awaseem