Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix end-to-end test to use packages from master #698

Closed
gaearon opened this issue Sep 22, 2016 · 5 comments · Fixed by #867
Closed

Fix end-to-end test to use packages from master #698

gaearon opened this issue Sep 22, 2016 · 5 comments · Fixed by #867

Comments

@gaearon
Copy link
Contributor

gaearon commented Sep 22, 2016

As noted in #696 (comment), we should have end-to-end test use the versions of packages from the repo instead of ones from npm. We might need to run lerna bootstrap in it or something.

@fson
Copy link
Contributor

fson commented Sep 22, 2016

It's weird that it only fails in Node v4.5.0, not in 6. We already run lerna bootstrap in the npm postinstall script so that should work.

I also tried running locally on a fresh Node v4.5.0 installation and npm install worked without any errors about peer dependencies.

@fson
Copy link
Contributor

fson commented Sep 22, 2016

I see what the problem is now, we run npm install again in the react-scripts package after copying it to a clean directory without node_modules. At that point the packages are not bootstrapped, so it installs all the packages from npm.

I think the release script possibly needs to be changed too, because it uses the same strategy when it bundles the dependencies. Unless we publish all the other packages first, the script will bundle the eslint-config-react-app from npm. Perhaps we could make this easier by publishing everything with lerna publish and moving the special handling for react-scrips to a prepublish script, so that it will (hopefully) run after the version numbers have been updated?

@fson
Copy link
Contributor

fson commented Sep 22, 2016

The e2e test should be fixed here: #699.

@gaearon
Copy link
Contributor Author

gaearon commented Sep 22, 2016

Thanks!

@gaearon gaearon closed this as completed Sep 22, 2016
@gaearon
Copy link
Contributor Author

gaearon commented Sep 23, 2016

#723 (comment)

@gaearon gaearon reopened this Sep 23, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants