-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Homebrew release #23
Comments
Adds a formula for https://github.com/facebook/dotslash. The tool helps download and run executables from the web. `brew audit --new` passes except that the repository is fewer than 30 days old.
I don't know if this is still accurate, but as of Homebrew/brew#10307 and https://github.com/orgs/Homebrew/discussions/412, Homebrew does not support bottling universal binaries. |
According to the detailed explanation given in the discussions linked above the Homebrew maintainers disagree with you. TL;DR They deliberately don't support universal binaries because it is problematic to cross-compile across the whole ecosystem and |
I believe the Homebrew release is not being done correctly.
For macOS, we release a universal binary:
dotslash/.github/workflows/release.yml
Lines 22 to 42 in 92fe071
As explained here:
dotslash/website/docs/installation.md
Lines 9 to 18 in 92fe071
But based on my read of how the Brew formula was created:
Homebrew/homebrew-core@8e53cba
and the subsequent changes to that file:
https://github.com/Homebrew/homebrew-core/commits/master/Formula/d/dotslash.rb
It looks like it is doing a simple
cargo install
, so it is not creating a universal binary.Can we work with the Homebrew maintainers to fix this?
The text was updated successfully, but these errors were encountered: