Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support early/mid/late <month> #35

Closed
pcgreat opened this issue Jun 2, 2017 · 7 comments
Closed

Support early/mid/late <month> #35

pcgreat opened this issue Jun 2, 2017 · 7 comments

Comments

@pcgreat
Copy link
Contributor

pcgreat commented Jun 2, 2017

e.g.
early June -> 06/01-06/10
mid June -> 06/11-06/20
late June -> 06/21-06/30

@patapizza
Copy link
Contributor

Hi @pcgreat, do you think you can implement this? Thanks!

@pcgreat
Copy link
Contributor Author

pcgreat commented Jun 5, 2017

@patapizza I will try my best

@Abhiroop
Copy link

Abhiroop commented Jun 8, 2017

@pcgreat I have the same requirement. Did you make any progress in it? Or I can try picking this up too.

@pcgreat
Copy link
Contributor Author

pcgreat commented Jun 8, 2017

@Abhiroop I am still reading the source code, and haven't made any real progress yet. You are more than welcome to pick it up

@serefayar
Copy link
Contributor

@pcgreat @Abhiroop I am not sure about the implementation.

@pcgreat
Copy link
Contributor Author

pcgreat commented Jun 13, 2017

@serefayar thanks for your implementation! I did try your commits and it's a good reference for me to learn. However, I notice something weird and not sure if that's something you can fix: "late July" points to the July of 2018. Ideally, "late July" can be July of 2017, and "late February" to be Feb of 2018 (future by default)

facebook-github-bot pushed a commit that referenced this issue Jun 16, 2017
Summary: Closes #43

Reviewed By: blandinw

Differential Revision: D5264974

Pulled By: patapizza

fbshipit-source-id: 0330f2b
@pcgreat
Copy link
Contributor Author

pcgreat commented Jun 17, 2017

thanks @serefayar Looks perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants