New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"next <day-of-week>" should be the day-of-week that comes next week #44
Comments
Thanks for being proactive and submitting a PR! :) Personally I've always been confused with this in English. For what I've seen, it seems like "next " is effectively the upcoming day of week, otherwise it requires disambiguation ("you mean this week or next week?"). I might be wrong though.
I would generally agree, though it's still ambiguous, since in the US Sunday is the first day of the week (vs Monday). Let's see: I would love if other folks can chime in too. |
@patapizza Thanks for your prompt reply and detailed explanations. Yeah, I agree that there is some confusion and ambiguity inside this question. I did find some discussions https://english.stackexchange.com/questions/36419/next-friday-vs-this-friday and https://www.quora.com/When-is-it-correct-to-use-the-term-next-Saturday-or-any-other-day and https://forum.wordreference.com/threads/when-is-next-saturday-last-monday.37415/ . Most people tend to use "this Thursday" to refer to the upcoming Thursday, and "next Thursday" for the Thursday in the following week. And just like you said, this is still ambiguous for the Sunday case, so I created a little poll in my company (US based): Say today is Sunday (06/18), when I say “next Thursday”, if you think it’s referring to Thursday (06/22), please vote 1️⃣ if you think it’s referring to Thursday (06/29), please vote 2️⃣ And finally I got 1 vote for 1️⃣ and 6 votes for 2️⃣ So these people do think Sunday is the first day of the week and "next " always refers to the following week. So based on your questions, here is my answers (with a small scale vote):
Yes.
We would think it's the following week in this case.
Yes.
We think it's the Thursday after the immediate one. However, the size of my poll is so small. So just like you said, other folks are more than welcome to provide their opinions. |
My 2 cents: Currently, when I pass in "next monday", the response will be the datetime for the next Monday that occurs, with no options. If I pass in "monday", it returns the next Monday with the previous and the following, so three options. Over 50% of my customers when using "next monday" actually mean "monday after next". I think it's just a colloquialism, but it would be great for the datetime to return 2 options; 1 for the next monday, and one for the monday after next, allowing me to confirm with my customer. Let me know if this doesn't make sense, would be happy to discuss further. |
Checking back on the above. |
This fell off the cracks, thanks for following up. It seems like returning both options under |
I took a passing glance through. Haskell isn't really my jam, but if you could point me to the right file(s) I can always take a stab at it. |
@individual11 As a starter, here is the English rule, and here is the helper function. |
if the refTime is Wednesday (today), "next Thursday" currently refers to Thursday tomorrow, which doesn't seem right. In my mind, "next Thursday" should always refer to the Thursday of next week. If you also agree with this, I can send a PR to fix it
The text was updated successfully, but these errors were encountered: