Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to readme file #22

Closed
deg opened this issue Jun 6, 2010 · 3 comments
Closed

Tweaks to readme file #22

deg opened this issue Jun 6, 2010 · 3 comments

Comments

@deg
Copy link

deg commented Jun 6, 2010

Thanks Steven, for the updated configuration and readme. It's great to see this evolve so quickly.

I have two more suggestions for the readme file:

  1. Correct the line "git clone git@github.com:facebook/facebook-android-sdk.git" to read "git clone http://github.com/facebook/facebook-android-sdk.git". That will allow everyone who has only read-only access to get the files.

  2. The line "If you already have an Android application, you can add a dependency to your application on the SDK by right-clicking on your project in the Package Explorer, selecting Properties, and adding the dependency in the Library section of the Android tab." is a bit vague. I've never imported a library into an Android project before, and the steps are not completely obvious. Even after two tries, I don't think I have it quite right yet.

Thanks,
David

@Aaron80b
Copy link

Aaron80b commented Jun 6, 2010

Once you get the properties dialog box open, on the left select "Android"
The "tab/page" is divided into 2 sections top and bottom... the top "Project Build Target" you can ignore that the bottom "Library" click add and select the facebookSDK

It might also be worth adding that when adding the library in the inital steps after this line: "Select the facebook subdirectory from within the git repository at the location."
I would add "Change the project name to "FacebookSDK"

@deg
Copy link
Author

deg commented Jun 7, 2010

Thanks. My problem was mostly my misreading... I had gone to the too-familiar Libraries tab of Java Build Path, instead of Android. Predictable confusion resulted.

Nonetheless, your fuller text will certainly help, even in cases like my confusion.

@soneff
Copy link

soneff commented Jun 7, 2010

Good feedback, I will push an updated README with these changes in a few minutes.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants