Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request protocol? #19

Closed
wzph opened this issue Aug 26, 2010 · 2 comments
Closed

Pull request protocol? #19

wzph opened this issue Aug 26, 2010 · 2 comments

Comments

@wzph
Copy link

wzph commented Aug 26, 2010

Hi there, and thanks for releasing the library on github.

I don't seem able to send a pull request to the github user "facebook." I've sent a couple to the user "yujuan"--is this the appropriate way to do it?

@yujuan
Copy link

yujuan commented Aug 26, 2010

Hi, wzph

Thanks a lot for your suggestions! For the change of the SDK, we usually first do internal change with test and code review, then we can push out the change to github. I am currently merging your change on my local copy and it would take effective in a few days. Thanks a lot and please keep sending your suggestion.

@wzph
Copy link
Author

wzph commented Aug 26, 2010

Super. Thank you for your response!

(Just added 4111109)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants