cannot git clone the source #1
Comments
|
Try this command: git clone git@github.com:facebook/facebook-ios-sdk.git |
caabernathy
pushed a commit
that referenced
this issue
Feb 7, 2012
Summary: Currently when there is a Platform API call that has any error or if there is a connection error, e.g. timeout, the access token is invalidated. This was due to diff D378197 where any errors call invalidSession. To fix this narrow the invalidate call to the scenario where the access token has expired when an API call is made. For now, only REST API error codes allow us to easily identify an invalid token (error code 190). A separate diff will be implemented by the Platform team to provide an error code for Graph API auth token errors. Test Plan: Case #1 1/ Login 2/ Tap Graph API 3/ Tap Get your friends 4/ Go off LAN and WiFi 5/ Tap Get your friends Case #2 1/ Turn WiFi back on 2/ Tap Get your friends 3/ See friends list 4/ Go back to get to Graph API page 5/ Remove app from https://www.facebook.com/settings/?tab=applications 6/ Tap Get your friends Case #3 1/ Temporarily modified code to force a Graph API error //[[delegate facebook] requestWithGraphPath:@"me" andParams:params andDelegate:self]; [[delegate facebook] requestWithGraphPath:@"000000" andParams:params andDelegate:self]; 2/ Tap Graph API 3/ Tap Get your information Before this change, here were the results Case #1: Session expires message, which is incorrect behavior Case #2: Session expires message, which is correct behavior Case #3: Session expires message, which is incorrect behavior After this change, here are the results Case #1: Get the Hackbook "Oops something went wrong" message, which is desired behavior Case #2: Get the Hackbook "Oops something went wrong" message, which is not ideal, user should also be logged out Case #3: Get the Hackbook "Oops something went wrong" message, which is desired behavior Reviewers: yariv, jimbru, brent, toddkrabach, jonathan Reviewed By: yariv CC: lshepard, selekman, beau, bgolub, danmuriello, jacl Differential Revision: https://phabricator.fb.com/D402481 Revert Plan: OK Task ID: 900407
ghost
pushed a commit
to WeTransferArchive/facebook-ios-sdk
that referenced
this issue
Mar 2, 2012
Summary: Currently when there is a Platform API call that has any error or if there is a connection error, e.g. timeout, the access token is invalidated. This was due to diff D378197 where any errors call invalidSession. To fix this narrow the invalidate call to the scenario where the access token has expired when an API call is made. For now, only REST API error codes allow us to easily identify an invalid token (error code 190). A separate diff will be implemented by the Platform team to provide an error code for Graph API auth token errors. Test Plan: Case facebook#1 1/ Login 2/ Tap Graph API 3/ Tap Get your friends 4/ Go off LAN and WiFi 5/ Tap Get your friends Case facebook#2 1/ Turn WiFi back on 2/ Tap Get your friends 3/ See friends list 4/ Go back to get to Graph API page 5/ Remove app from https://www.facebook.com/settings/?tab=applications 6/ Tap Get your friends Case facebook#3 1/ Temporarily modified code to force a Graph API error //[[delegate facebook] requestWithGraphPath:@"me" andParams:params andDelegate:self]; [[delegate facebook] requestWithGraphPath:@"000000" andParams:params andDelegate:self]; 2/ Tap Graph API 3/ Tap Get your information Before this change, here were the results Case facebook#1: Session expires message, which is incorrect behavior Case facebook#2: Session expires message, which is correct behavior Case facebook#3: Session expires message, which is incorrect behavior After this change, here are the results Case facebook#1: Get the Hackbook "Oops something went wrong" message, which is desired behavior Case facebook#2: Get the Hackbook "Oops something went wrong" message, which is not ideal, user should also be logged out Case facebook#3: Get the Hackbook "Oops something went wrong" message, which is desired behavior Reviewers: yariv, jimbru, brent, toddkrabach, jonathan CC: lshepard, selekman Differential Revision: https://phabricator.fb.com/D402481 Revert Plan: OK Task ID: 900407
joesus
pushed a commit
that referenced
this issue
Aug 27, 2019
Update CocoaPods settings and re-enable linting on Travis-CI.
5 tasks
5 tasks
facebook-github-bot
pushed a commit
that referenced
this issue
May 22, 2021
Summary: The existing code that was removed was doing 2 things. 1. It was verifying the `request.graphPath` and 2. it was verifying that `loadProfileWithToken:completion:graphRequest:` would be called when `loadProfileWithToken:completion:` was called. For #1. I moved the code that creates the graph path into a new `graphPathForToken:` method which the existing `loadProfileWithToken:completion:` will call. The test will call the `graphPathForToken:` method directly to get this information (instead of reaching into the `loadProfileWithToken:completion:graphRequest:` method as it was doing before. For #2. I deleted the code since it really isn't necessary to verify that `loadProfileWithToken:completion:graphRequest:` is called when `loadProfileWithToken:completion:` is called since that's all the method does (after creating the graph path and graph request, so it will always be called). I think it was being verified before just because OCMock needed to call the method anyway in order to grab the request object to check the path. Also the `testGraphPathForProfileLoadWithFriendsPermission` test was actually verifying the graphPath twice. Once in the method itself and once with the `verifyGraphPath` call which did the exact same thing. Removed the extra check in the method itself. Reviewed By: joesus Differential Revision: D28616761 fbshipit-source-id: 41a8a3a0e9ad719382be8de95aafe847eaffdfd3
5 tasks
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
when I perform the git clone in macosx, error "the remote end hung up unexpectedly" is reported. Then I tried the git clone http://....... it asks me for a username and password... and I cannot go through that.. Authentication failed.
So, what should I do??
The text was updated successfully, but these errors were encountered: