Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16.2.0 has not updated the remote binary url for the remote target from v16.1.3 #2282

Open
5 tasks done
termorrell opened this issue Oct 11, 2023 · 2 comments
Open
5 tasks done

Comments

@termorrell
Copy link

Checklist before submitting a bug report

Xcode version

15.0

Facebook iOS SDK version

16.2.0

Dependency Manager

SPM

SDK Framework

Core

Goals

Add FBCore v16.2.0 as a dependency to our project.

Expected results

The dependency added to our project should be v16.2.0

Actual results

The SPM definition appears to still bring in a remote binary for the target that is build against v16.1.3

Steps to reproduce

We are on the Alpha for SKAdNetwork v4.0. We integrated with SPM targeting v16.2.0. After speaking with Meta they raised that they could see were still on SDK. v16.1.3. It looks like the release is still targeting a remote binary for v16.1.3

"https://github.com/facebook/facebook-ios-sdk/releases/download/v16.1.3/\(targetName)-Static_XCFramework.zip"

I can see from the commit history that this is normally updated shortly after a release.

Code samples & details

// INSERT YOUR CODE HERE
var example = "Example code"
@termorrell
Copy link
Author

My colleague has raised a PR to address this issue. #2284

@kurtby
Copy link

kurtby commented Oct 13, 2023

and no fix yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants