Bug in FBRequest

[virajmody]

The FBRequest class needs to retain/release the delegate passed in.

Here's a case where it can crash:

• User code creates a Facebook instance and calls -logout:self
• Facebook code creates a FBRequest and issues a server call to logout, but it invokes the fbDidLogout delegate immediately (which is another bug, IMHO)
• when user code gets told logout is done, it correctly releases the Facebook instance
• server request from FB completes and it tries to invoke the delegate (the FB instance that is now gone) and crashes.

The fix is to retain the delegate passed to the FBRequest object in FBRequest.m

[yujuan]

just check in the fix. Thanks!

[chrismoos]

I see this issue was closed, but it does still occur if the delegate has already been released when the FBRequest finishes.

virajmody mentioned the solution of retaining the delegate. This is fine as long as we ensure that the delegate is released after sending it message(s) (such as didReceiveResponse: or didFailWithError:).

I'd be happy to do this fix.