Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoUtils.waitForVideoEncoding does not handle failure correctly #32

Closed
kilink opened this issue Jun 28, 2016 · 1 comment
Closed

VideoUtils.waitForVideoEncoding does not handle failure correctly #32

kilink opened this issue Jun 28, 2016 · 1 comment
Assignees
@JiamingFB

Comments

@kilink
Copy link
Contributor

kilink commented Jun 28, 2016

VideoUtils.waitForVideoEncoding will continue retrying even when the call to getVideoStatus indicates that there was an error (it only ever checks if the status is "ready"). It should probably instead return false or throw an exception.
@JiamingFB JiamingFB self-assigned this Jul 5, 2016
@kilink kilink mentioned this issue Aug 31, 2016
Merged
@cloudxu
Copy link
Contributor

cloudxu commented Sep 2, 2016

I'll merge this with your pull request. Thanks @kilink.

@cloudxu cloudxu closed this as completed Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiamingFB JiamingFB

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kilink @cloudxu @JiamingFB