Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading video caption file fails #55

Closed
kilink opened this issue Oct 18, 2016 · 1 comment
Closed

Uploading video caption file fails #55

kilink opened this issue Oct 18, 2016 · 1 comment

Comments

@kilink
Copy link
Contributor

kilink commented Oct 18, 2016

Uploading of video captions fails due to the way the default request executor determines mime types based on file extension; it uses a fixed mapping that doesn't include ".srt", so the Facebook API endpoint rejects the request.

A more foolproof method would be to fall back to a default mimetype such as "application/octet-stream" when one can't be determined based on file extension. Files.probeContentType could also be utilized to delegate to more sophisticated user supplied file type detectors such as Tika.

@daphyFB
Copy link
Contributor

daphyFB commented Oct 18, 2016

Hi, thanks for reporting the Ads API SDK bug! Since this will be addressed by #56, I'll close this issue. Thanks a lot again!

@daphyFB daphyFB closed this as completed Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants