Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong case of properties in ads-insight object #15

Closed
perengb opened this issue Nov 16, 2017 · 2 comments
Closed

Wrong case of properties in ads-insight object #15

perengb opened this issue Nov 16, 2017 · 2 comments

Comments

@perengb
Copy link

perengb commented Nov 16, 2017 •
edited

Got this error when calling the API using properties from the ads-insight object:

"(#100) breakdowns[0] must be one of the following values: age, country, dma, gender, frequency_value, hourly_stats_aggregated_by_advertiser_time_zone, hourly_stats_aggregated_by_audience_time_zone, impression_device, place_page_id, publisher_platform, platform_position, device_platform, product_id, region"

The HTTP call sent has the breakdowns in uppercase like this:
breakdowns: PUBLISHER_PLATFORM,IMPRESSION_DEVICE

Made a pull request to fix:
#14
@perengb
Copy link
Author

perengb commented Dec 4, 2017

Is there something more that i need to do in order to merge this PR?

@vicdus
Copy link
Contributor

vicdus commented Jun 19, 2018

PR already accepted. Thanks!

@vicdus vicdus closed this as completed Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vicdus @perengb